Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-46114: Fix OpenSSL version check for 3.0.1 (GH-30170) #92954

Merged
merged 1 commit into from Jun 6, 2022
Merged

[3.8] bpo-46114: Fix OpenSSL version check for 3.0.1 (GH-30170) #92954

merged 1 commit into from Jun 6, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 19, 2022

(cherry picked from commit 2985fea)

@vstinner vstinner requested a review from tiran as a code owner May 19, 2022
@bedevere-bot bedevere-bot mentioned this pull request May 19, 2022
Merged
@bedevere-bot bedevere-bot added tests awaiting core review labels May 19, 2022
@vstinner
Copy link
Member Author

@vstinner vstinner commented May 19, 2022

test_ssl fails on multiple buildbots because it lacks this fix. Example with aarch64 Fedora Rawhide 3.8:
https://buildbot.python.org/all/#/builders/173/builds/67

test.pythoninfo:

ssl.OPENSSL_VERSION: OpenSSL 3.0.2 15 Mar 2022
ssl.OPENSSL_VERSION_INFO: (3, 0, 0, 2, 0)

@vstinner
Copy link
Member Author

@vstinner vstinner commented May 19, 2022

Recent failure on AMD64 Fedora Rawhide Refleaks 3.8 buildbot:
https://buildbot.python.org/all/#/builders/355/builds/396

FAIL: test_openssl_version (test.test_ssl.BasicSocketTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.8.cstratak-fedora-rawhide-x86_64.refleak/build/Lib/test/test_ssl.py", line 594, in test_openssl_version
    self.assertTrue(s.startswith("OpenSSL {:d}.{:d}.{:d}".format(major, minor, fix)),
AssertionError: False is not true : ('OpenSSL 3.0.2 15 Mar 2022', (3, 0, 0, 2, 0), '0x30000020')

@vstinner vstinner mentioned this pull request May 19, 2022
Closed
@vstinner
Copy link
Member Author

@vstinner vstinner commented May 23, 2022

cc @tiran @stratakis

@ambv ambv merged commit 067c372 into python:3.8 Jun 6, 2022
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vstinner @ambv @bedevere-bot @tiran