Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-90699: Intern statically allocated strings #93597

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GH-90699: Intern statically allocated strings #93597

wants to merge 3 commits into from
+627 −6

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 8, 2022 •
edited

This is similar to how strings are interned for deepfreeze.

@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots label Jun 8, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 8, 2022

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit f0e01c4 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Jun 8, 2022
@kumaraditya303 kumaraditya303 marked this pull request as ready for review Jun 8, 2022
@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jun 8, 2022

Should pycore_runtime_init.h be marked as generated?

cpython/.gitattributes

Lines 69 to 71 in 243ed54

Include/internal/pycore_ast.h generated
Include/internal/pycore_ast_state.h generated
Include/internal/pycore_opcode.h generated

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev

@gvanrossum gvanrossum

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kumaraditya303 @bedevere-bot @AA-Turner @arhadthedev