Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44235: Remove deprecated functions in the gettext module. #26378

Merged
merged 4 commits into from May 30, 2021
Merged

bpo-44235: Remove deprecated functions in the gettext module. #26378

merged 4 commits into from May 30, 2021

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented May 26, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44235
@corona10 corona10 changed the title bpo-44235: Remove deprecated functions in the gettext module. [WIP] bpo-44235: Remove deprecated functions in the gettext module. May 26, 2021
@corona10 corona10 changed the title [WIP] bpo-44235: Remove deprecated functions in the gettext module. bpo-44235: Remove deprecated functions in the gettext module. May 26, 2021
@corona10 corona10 requested a review from serhiy-storchaka May 26, 2021
serhiy-storchaka
serhiy-storchaka requested changes May 26, 2021
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Remove unused global variables and attributes.

Doc/library/gettext.rst Show resolved Hide resolved
Doc/library/gettext.rst Show resolved Hide resolved
Lib/gettext.py Outdated Show resolved Hide resolved
Lib/gettext.py Outdated Show resolved Hide resolved
Lib/gettext.py Show resolved Hide resolved
Lib/gettext.py Show resolved Hide resolved
Lib/test/test_gettext.py Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 26, 2021

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10 corona10 force-pushed the bpo-44235 branch 2 times, most recently from d38f80c to a5f6758 May 27, 2021
@corona10
Copy link
Member Author

@corona10 corona10 commented May 27, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 27, 2021

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed May 29, 2021
View changes
Lib/gettext.py Outdated Show resolved Hide resolved
@corona10 corona10 merged commit 14ba761 into python:main May 30, 2021
12 checks passed
@corona10 corona10 deleted the bpo-44235 branch May 30, 2021
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@corona10 @JuniorJPDJ
bpo-44235: Remove deprecated functions in the gettext module. (python…
ffcb140 
…GH-26378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
4 participants
@corona10 @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni