Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42958: Update filecmp.cmp docs #27166

Merged
merged 3 commits into from Aug 4, 2021
Merged

bpo-42958: Update filecmp.cmp docs #27166

merged 3 commits into from Aug 4, 2021

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented Jul 15, 2021 •
edited by bedevere-bot

This was referenced Aug 4, 2021
Closed
Closed
@ambv @AlexVndnblcke
Reword to include @AlexVndnblcke's suggestions and restore natural la…
042be98 
…nguage flow

Co-authored-by: Alexander Vandenbulcke <alexander.vandenbulcke95@gmail.com>
@ambv ambv merged commit a8dc489 into python:main Aug 4, 2021
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 4, 2021

Thanks @akulakov for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2021
@akulakov @miss-islington
bpo-42958: Improve description of shallow= in filecmp.cmp docs (pytho…
ee376e3 
…nGH-27166)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Alexander Vandenbulcke <alexander.vandenbulcke95@gmail.com>
(cherry picked from commit a8dc489)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 4, 2021

GH-27607 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2021
@akulakov @miss-islington
bpo-42958: Improve description of shallow= in filecmp.cmp docs (pytho…
62c3d53 
…nGH-27166)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Alexander Vandenbulcke <alexander.vandenbulcke95@gmail.com>
(cherry picked from commit a8dc489)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 4, 2021

GH-27608 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Aug 4, 2021
@miss-islington @akulakov
bpo-42958: Improve description of shallow= in filecmp.cmp docs (GH-27166
c2593b4 
)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Alexander Vandenbulcke <alexander.vandenbulcke95@gmail.com>
(cherry picked from commit a8dc489)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
ambv pushed a commit that referenced this pull request Aug 4, 2021
@miss-islington @akulakov
bpo-42958: Improve description of shallow= in filecmp.cmp docs (GH-27166
7dad033 
) (GH-27608)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Alexander Vandenbulcke <alexander.vandenbulcke95@gmail.com>
(cherry picked from commit a8dc489)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akulakov @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni