New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46522: fix concurrent.futures and io AttributeError messages #30887
bpo-46522: fix concurrent.futures and io AttributeError messages #30887
Conversation
other examples of module dunder AttributeError: cpython/Lib/zoneinfo/__init__.py Line 27 in 99b0a6d
Line 793 in ee60550
cpython/Lib/unittest/__init__.py Line 94 in ee60550
this one doesn't use cpython/Lib/sqlite3/__init__.py Line 71 in ee60550
interestingly, this is actually the correct form:
so they should all be: AttributeError(f"module '{__name__}' has no attribute '{name}'") |
The error message text is changed. While the text is not a part of stable API and can be wildly changed, we usually don't do it in bugfix releases without a strong reason. |
Misc/NEWS.d/next/Library/2022-01-25-15-31-04.bpo-46522.tYAlX4.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
I have made the requested changes; please review again |
Thanks for making the requested changes! @asvetlov: please review the changes made to this pull request. |
thanks! |
https://bugs.python.org/issue46522