New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-90494: Reject 6th element of the __reduce__() tuple #93609
Merged
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:copy-reduce-6tuple
Jun 9, 2022
Merged
gh-90494: Reject 6th element of the __reduce__() tuple #93609
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:copy-reduce-6tuple
Jun 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copy.copy() and copy.deepcopy() now always raise a TypeError if __reduce__() returns a tuple with length 6 instead of silently ignore the 6th item or produce incorrect result.
rhettinger
approved these changes
Jun 8, 2022
Thanks @serhiy-storchaka for the PR |
GH-93631 is a backport of this pull request to the 3.11 branch. |
GH-93632 is a backport of this pull request to the 3.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
copy.copy()
andcopy.deepcopy()
now always raise a TypeError if__reduce__()
returns a tuple with length 6 instead of silently ignorethe 6th item or produce incorrect result.
Closes #90494.