Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42047: DragonFlyBSD thread native id support. #22714

Merged
merged 8 commits into from May 18, 2022
Merged

bpo-42047: DragonFlyBSD thread native id support. #22714

merged 8 commits into from May 18, 2022
+11 −3

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Oct 15, 2020 •
edited by bedevere-bot

Fidget-Spinner
Fidget-Spinner reviewed Oct 16, 2020
View changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

LGTM, just one minor nitpick on news

Misc/NEWS.d/next/Library/2020-10-15-18-37-12.bpo-42047.XDdoSF.rst Outdated Show resolved Hide resolved
@devnexen @Fidget-Spinner
Update Misc/NEWS.d/next/Library/2020-10-15-18-37-12.bpo-42047.XDdoSF.rst
ba9f74a 
Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>
@github-actions
Copy link

@github-actions github-actions bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Dec 16, 2020
@devnexen
Copy link
Contributor Author

@devnexen devnexen commented Dec 16, 2020

ping :)

@github-actions github-actions bot removed the stale label Dec 17, 2020
erlend-aasland
erlend-aasland reviewed May 18, 2022
View changes
Include/pythread.h Outdated Show resolved Hide resolved
vstinner
vstinner reviewed May 18, 2022
View changes
Include/pythread.h Outdated Show resolved Hide resolved
@erlend-aasland @vstinner
Break long line
5a54ad2 
Co-authored-by: Victor Stinner <vstinner@python.org>
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 18, 2022

Please also update the availability annotation of get_native_id in the docs:

  • Doc/library/_thread.rst
  • Doc/library/threading.rst

See gh-13624 for inspiration :)

@erlend-aasland erlend-aasland self-assigned this May 18, 2022
erlend-aasland
erlend-aasland requested changes May 18, 2022
View changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Please resolve #22714 (comment)

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 18, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@devnexen
Copy link
Contributor Author

@devnexen devnexen commented May 18, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 18, 2022

Thanks for making the requested changes!

@erlend-aasland, @Fidget-Spinner: please review the changes made to this pull request.

@erlend-aasland erlend-aasland merged commit 9a1adf2 into python:main May 18, 2022
13 checks passed
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 18, 2022

Thanks, @devnexen!

@erlend-aasland erlend-aasland mentioned this pull request May 18, 2022
Closed
@vstinner
Copy link
Member

@vstinner vstinner commented May 18, 2022

Maybe POSIX should do something and create a portable API for this function :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@erlend-aasland erlend-aasland

@Fidget-Spinner Fidget-Spinner

Assignees

@erlend-aasland erlend-aasland

Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@devnexen @erlend-aasland @bedevere-bot @vstinner @Fidget-Spinner @the-knights-who-say-ni