gh-72572: Remove mention of synced None returns for utcoffset() and dst() #93001
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per my comment here, I'm thinking maybe we should change the behavior of |
|
Hmm, it's also possible to keep the wording but soften it, like '... should generally not ...', and actually I think the current wording is technically fine, since it doesn't say something like 'must not'. Timezone just needs some justification on why it violates the mandate, if there is a reason for it |
|
I don't think we should document that it's OK for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#72572
All methods of
tzinfonow already mention the circumstances that they returnNone. Timezone does also appear to violate the removed statement:timezone.dststates that it always returnsNone, while that's not the case fortimezone.utcoffset.