test_subprocess is one of our long running tests, this slows down CI and buildbots. There is room for improvement in its total execution time.

Use this issue as a rollup issue for any such work. we need to keep it reliable, just focus on reducing either user/sys cpu time or wall time.

New changeset 67b93f8 by Gregory P. Smith in branch 'master':
bpo-38456: Use /bin/true in test_subprocess (GH-16736)
67b93f8

New changeset 46113e0 by Pablo Galindo in branch 'master':
bpo-38456: Handle the case when there is no 'true' command (GH-16739)
46113e0

New changeset 4f0587f by Gregory P. Smith in branch '3.8':
[3.8] bpo-38456: Use /bin/true in test_subprocess (GH-16737)
4f0587f

Nice. Any idea of the speedup on Travis CI and/or on a specific buildbot worker?

I assume the CI systems are shared and potentially noisy. It should be easier to look at some logs from slower buildbots. but sadly test_subprocess has fallen off the list of "10 slowest tests" that timing info is supplied for. concurrent.futures, multiprocessing, asyncio, tokenize, etc. all take longer.

I still don't expect it to be more than a few seconds.

the slowest tests on Linux today (with number of seconds prepended on my system that runs the suite serially in 34 seconds on a debug build):

3.01 test_check_output_stdout_arg (test.test_subprocess.ProcessTestCaseNoPoll) ... ok
3.01 test_check_output_stdout_arg (test.test_subprocess.ProcessTestCase) ... ok
3.0 test_check_output_stdin_with_input_arg (test.test_subprocess.RunFuncTestCase) ... ok
2.28 test_issue8780 (test.test_subprocess.ProcessTestCase) ... ok
2.27 test_issue8780 (test.test_subprocess.ProcessTestCaseNoPoll) ... ok
2.04 test_communicate_BrokenPipeError_stdin_write (test.test_subprocess.POSIXProcessTestCase) ... ok
1.45 test_leak_fast_process_del_killed (test.test_subprocess.POSIXProcessTestCase) ... ok
1.04 test_communicate_stdout (test.test_subprocess.ProcessTestCase) ... ok
1.03 test_communicate_stdout (test.test_subprocess.ProcessTestCaseNoPoll) ... ok
1.03 test_kill (test.test_subprocess.POSIXProcessTestCase) ... ok
1.03 test_send_signal (test.test_subprocess.POSIXProcessTestCase) ... ok
1.03 test_terminate (test.test_subprocess.POSIXProcessTestCase) ... ok
0.636 test_communicate_timeout (test.test_subprocess.ProcessTestCase) ... ok
0.636 test_communicate_timeout (test.test_subprocess.ProcessTestCaseNoPoll) ... ok
0.58 test_swap_fds (test.test_subprocess.POSIXProcessTestCase) ... ok

fyi - handy command to get that

python -m test.regrtest -v test_subprocess | ts '.%s'

then process that using whatever you want to compute deltas and sort. i fed the output of that into:

#!/usr/bin/python3
"""Parse `python -m test.regrtest -v | ts '.%s'` output, report slowest."""

import sys
from typing import Sequence, Tuple


infile = sys.stdin

deltas: Sequence[Tuple[float, str]] = []

prev_secs: float = 0.
prev_test: str = ''
for line in infile:
  stripped_line = line.strip()
  if ' ' not in stripped_line:
    continue
  num, test = stripped_line.split(None, 1)
  secs = float(num)
  delta = secs - prev_secs if prev_secs else 0.
  if '... ok' or '... skipped' in test:  # Not extraneous output.
    # Assign the accumulated time to the previous test.
    deltas.append((delta, prev_test))
    prev_secs = secs
    prev_test = test

for secs, test in reversed(sorted(deltas, key=lambda x:x[0])[-23:]):
  print(f'{secs:.3} {test}')