Skip to content

bpo-46447: Add doc warning about using naive datetimes in isoformat #30850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jeanCarloMachado
Copy link

@jeanCarloMachado jeanCarloMachado commented Jan 24, 2022

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jan 24, 2022
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@jeanCarloMachado

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@MaxwellDupre
Copy link
Contributor

Your changes at line 1476 are in IMHO are in the wrong place, in any they should be at the start under the 'Aware and Naive Objects' heading and the text there should be adapted if needed and I am not sure that it should!
Finally, your explanation is not very clear, plus you need to heed the comments in the bug report.

@serhiy-storchaka
Copy link
Member

This proposition has been rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants