Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perfomance fixes, eslint fixes #4482

Merged
merged 1 commit into from Sep 26, 2019
Merged

Conversation

anatoliy8493
Copy link
Contributor

@anatoliy8493 anatoliy8493 commented Sep 25, 2019

No description provided.

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Sep 25, 2019

CLA assistant check
All committers have signed the CLA.

@falsyvalues
Copy link
Member

@falsyvalues falsyvalues commented Sep 26, 2019

Hi @anatoliy8493!
Thank you, we are fine with current solution.

@jdalton
Copy link
Member

@jdalton jdalton commented Sep 26, 2019

Thank you @falsyvalues!

Ya know, after all these years I think it's time we go === :p
It's easy for new contributors to reason about.

@jdalton jdalton merged commit 898b378 into lodash:master Sep 26, 2019
1 check passed
@falsyvalues
Copy link
Member

@falsyvalues falsyvalues commented Sep 26, 2019

@jdalton Sure thing 👍 but calling that performance fixes 🙈

@jdalton
Copy link
Member

@jdalton jdalton commented Sep 26, 2019

🙃

@anatoliy8493
Copy link
Contributor Author

@anatoliy8493 anatoliy8493 commented Sep 26, 2019

@falsyvalues Hi! It might seem like a strong word, however if we use === instead of == we no need to JS Type Conversion

@jdalton
Copy link
Member

@jdalton jdalton commented Sep 27, 2019

In this case our usage of == was when there was no type conversion so basically spec'd identical steps as ===. There is no meaningful performance difference with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants