Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license headers throughout the repo. #37205

Closed
wants to merge 2 commits into from

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented May 19, 2020

See individual commits.

While this changes a large number of files in the repo, it does not cause many conflicts/churn in pending work.

$ yarn -s ng-dev pr discover-new-conflicts 37205
Requesting pending PRs from Github
Retrieved 605 total pending PRs
Checking 128 PRs for conflicts after a merge of #37205
[========================================] ETA: 0s | 128/128

Result:
2 PR(s) which conflict(s) after #37205 merges:
  - 36425: build: remove source-map-test gulp script
  - 37190: deprecate Bazel builder in @angular/bazel

@josephperrott josephperrott added state: WIP comp: build & ci target: patch labels May 19, 2020
@ngbot ngbot bot added this to the needsTriage milestone May 19, 2020
@josephperrott josephperrott marked this pull request as ready for review May 19, 2020
@josephperrott josephperrott added action: merge and removed state: WIP labels May 19, 2020
@josephperrott josephperrott requested a review from IgorMinar May 19, 2020
Copy link
Contributor

@IgorMinar IgorMinar left a comment

lgtm, but let's hold off with this change until after rc.0 so that we don't disrupt the rc-related work. It should be relatively easy to recreate/update this PR, so I hope that delaying the merge a bit is not a big issue.

Reviewed-for: global-approvers

browser-providers.conf.js Show resolved Hide resolved
@josephperrott
Copy link
Member Author

@josephperrott josephperrott commented May 19, 2020

@IgorMinar As noted in the PR description, this PR only causes conflicts in 2 PRs (one of them mine, and its a conflict because a file gets removed that modified here). Since it does not disrupt any work in any other pending PRs I believe it is safe to land immediately.

Update the file-header lint rule to properly reference Google LLC
rather than Google Inc, for the required headers.
Update the license headers throughout the repository to reference Google LLC
rather than Google Inc, for the required license headers.
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Reviewed-for: global-approvers

@matsko matsko closed this in 5aeb9a4 May 26, 2020
matsko pushed a commit that referenced this issue May 26, 2020
Update the license headers throughout the repository to reference Google LLC
rather than Google Inc, for the required license headers.

PR Close #37205
matsko pushed a commit that referenced this issue May 26, 2020
Update the file-header lint rule to properly reference Google LLC
rather than Google Inc, for the required headers.

PR Close #37205
matsko pushed a commit that referenced this issue May 26, 2020
Update the license headers throughout the repository to reference Google LLC
rather than Google Inc, for the required license headers.

PR Close #37205
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jun 26, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
profanis pushed a commit to profanis/angular that referenced this issue Sep 5, 2020
Update the file-header lint rule to properly reference Google LLC
rather than Google Inc, for the required headers.

PR Close angular#37205
profanis pushed a commit to profanis/angular that referenced this issue Sep 5, 2020
Update the license headers throughout the repository to reference Google LLC
rather than Google Inc, for the required license headers.

PR Close angular#37205
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge cla: yes comp: build & ci target: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants