Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update default circle ci image to cimg/node:14.17.6 #43810

Closed

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Oct 12, 2021

build(docs-infra): update min range of node versions
Eslint 8 which is used in AIO requires Node.js 14.17.x or later.

ci: update default circle ci image to cimg/node:14.17.6
With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images circleci/node with the new images cimg/node.

See: https://circleci.com/developer/images/image/cimg/node

ci: use Node.js browsers image

Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host.
install_chrome_libs however takes takes ~13s every-time.

@google-cla google-cla bot added the cla: yes label Oct 12, 2021
@alan-agius4 alan-agius4 force-pushed the ci-update-circle-images branch 2 times, most recently from 9f0e63f to d426631 Compare Oct 12, 2021
@alan-agius4 alan-agius4 added comp: build & ci target: rc labels Oct 12, 2021
@ngbot ngbot bot added this to the Backlog milestone Oct 12, 2021
@ngbot ngbot bot added this to the Backlog milestone Oct 12, 2021
@alan-agius4 alan-agius4 marked this pull request as ready for review Oct 12, 2021
@pullapprove pullapprove bot requested a review from filipesilva Oct 12, 2021
@alan-agius4 alan-agius4 requested review from josephperrott and removed request for filipesilva Oct 12, 2021
@alan-agius4 alan-agius4 force-pushed the ci-update-circle-images branch 5 times, most recently from db68f0e to cb6f525 Compare Oct 12, 2021
alan-agius4 added 3 commits Oct 12, 2021
With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images `circleci/node` with the new images `cimg/node`.

See: https://circleci.com/developer/images/image/cimg/node
Eslint 8 which is used in AIO requires Node.js `14.17.x` or later.
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. `install_chrome_libs` however takes takes ~13s everytime.
Copy link
Member

@gkalpak gkalpak left a comment

🎉

Commit message typo:

-Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. 
+Spinning up a Node.js browsers image has little to no overhead when the image is cached on the host. 

Question: How likely is it for the image to be cached on the host? 🤔

aio/package.json Outdated Show resolved Hide resolved
@alan-agius4
Copy link
Contributor Author

@alan-agius4 alan-agius4 commented Oct 12, 2021

@gkalpak, the commit message is actual correct. I did mean is not cached. Using a browsers image has little to no overhead when compared to the non-browsers image even when it's not cached.

When the image is cached on host there isn't any overhead.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Oct 12, 2021

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Oct 12, 2021

@alan-agius4 alan-agius4 self-assigned this Oct 12, 2021
.circleci/config.yml Show resolved Hide resolved
@alan-agius4 alan-agius4 requested a review from gkalpak Oct 12, 2021
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Member

@gkalpak gkalpak left a comment

🚀

Copy link
Member

@josephperrott josephperrott left a comment

LGTM

@alan-agius4 alan-agius4 added action: merge and removed action: review labels Oct 12, 2021
@atscott
Copy link
Contributor

@atscott atscott commented Oct 12, 2021

This PR was merged into the repository by commit 17f5299.

atscott pushed a commit that referenced this issue Oct 12, 2021
Eslint 8 which is used in AIO requires Node.js `14.17.x` or later.

PR Close #43810
atscott pushed a commit that referenced this issue Oct 12, 2021
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. `install_chrome_libs` however takes takes ~13s everytime.

PR Close #43810
atscott pushed a commit that referenced this issue Oct 12, 2021
With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images `circleci/node` with the new images `cimg/node`.

See: https://circleci.com/developer/images/image/cimg/node

PR Close #43810
atscott pushed a commit that referenced this issue Oct 12, 2021
Eslint 8 which is used in AIO requires Node.js `14.17.x` or later.

PR Close #43810
atscott pushed a commit that referenced this issue Oct 12, 2021
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. `install_chrome_libs` however takes takes ~13s everytime.

PR Close #43810
@alan-agius4 alan-agius4 deleted the ci-update-circle-images branch Oct 12, 2021
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Nov 12, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge cla: yes comp: build & ci target: rc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants