New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update default circle ci image to cimg/node:14.17.6
#43810
Conversation
9f0e63f
to
d426631
Compare
db68f0e
to
cb6f525
Compare
With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images `circleci/node` with the new images `cimg/node`. See: https://circleci.com/developer/images/image/cimg/node
Eslint 8 which is used in AIO requires Node.js `14.17.x` or later.
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. `install_chrome_libs` however takes takes ~13s everytime.
cb6f525
to
c851c51
Compare
Commit message typo:
-Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host.
+Spinning up a Node.js browsers image has little to no overhead when the image is cached on the host.
Question: How likely is it for the image to be cached on the host?
@gkalpak, the commit message is actual correct. I did mean When the image is cached on host there isn't any overhead. |
You can preview b9c592b at https://pr43810-b9c592b.ngbuilds.io/. |
c477321
to
c001614
Compare
c001614
to
0bd72e1
Compare
You can preview 0bd72e1 at https://pr43810-0bd72e1.ngbuilds.io/. |
cb5ea46
to
71b9311
Compare
This PR was merged into the repository by commit 17f5299. |
Eslint 8 which is used in AIO requires Node.js `14.17.x` or later. PR Close #43810
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. `install_chrome_libs` however takes takes ~13s everytime. PR Close #43810
With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images `circleci/node` with the new images `cimg/node`. See: https://circleci.com/developer/images/image/cimg/node PR Close #43810
Eslint 8 which is used in AIO requires Node.js `14.17.x` or later. PR Close #43810
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. `install_chrome_libs` however takes takes ~13s everytime. PR Close #43810
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
build(docs-infra): update min range of node versions
Eslint 8 which is used in AIO requires Node.js
14.17.x
or later.ci: update default circle ci image to
cimg/node:14.17.6
With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images
circleci/node
with the new imagescimg/node
.See: https://circleci.com/developer/images/image/cimg/node
ci: use Node.js browsers image
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host.
install_chrome_libs
however takes takes ~13s every-time.