build: update repository to node@16 locally #44211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
comp: build & ci
In node@16 the URL constructor fails for for a malformed URL such as http://<empty>/. Instead http://_empty_ is used as this conveys the same information in tests but is correctly formed.
As node 16 is now active LTS, updating to node 16 is a better choice for our own development. Notably its support for M1 chips is an important value add for us.
AndrewKushnir
approved these changes
Nov 21, 2021
|
@josephperrott just wanted to ask if this PR is ready for merge :) |
|
This PR was merged into the repository by commit 0ad0054. |
jessicajaniuk
pushed a commit
that referenced
this issue
Nov 24, 2021
As node 16 is now active LTS, updating to node 16 is a better choice for our own development. Notably its support for M1 chips is an important value add for us. PR Close #44211
jessicajaniuk
pushed a commit
that referenced
this issue
Nov 24, 2021
As node 16 is now active LTS, updating to node 16 is a better choice for our own development. Notably its support for M1 chips is an important value add for us. PR Close #44211
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this issue
Dec 28, 2021
…gular#44211) In node@16 the URL constructor fails for for a malformed URL such as http://<empty>/. Instead http://_empty_ is used as this conveys the same information in tests but is correctly formed. PR Close angular#44211
dimakuba
pushed a commit
to dimakuba/angular
that referenced
this issue
Dec 28, 2021
As node 16 is now active LTS, updating to node 16 is a better choice for our own development. Notably its support for M1 chips is an important value add for us. PR Close angular#44211
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As node 16 is now active LTS, updating to node 16 is a better choice for our own development. Notably its
support for M1 chips is an important value add for us.