Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable Android 12 for tests on CI #45926

Closed
wants to merge 1 commit into from
Closed

ci: enable Android 12 for tests on CI #45926

wants to merge 1 commit into from
+11 −9

Conversation

AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented May 8, 2022

This commit updates SauceLabs config to use Android 12 and drop Android 10, so we maintain 2 most recent versions according to https://angular.io/guide/browser-support.

PR Type

What kind of change does this PR introduce?

  • CI related changes

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added state: WIP comp: build & ci target: rc labels May 8, 2022
@AndrewKushnir AndrewKushnir requested a review from devversion May 8, 2022
@ngbot ngbot bot added this to the Backlog milestone May 8, 2022
devversion
devversion previously approved these changes May 9, 2022
View changes
browser-providers.conf.js Show resolved Hide resolved
browser-providers.conf.js Show resolved Hide resolved
@AndrewKushnir
ci: enable Android 12 for tests on CI
07e8ca0 
This commit updates SauceLabs config to use Android 12 and drop Android 10, so we maintain 2 most recent versions according to https://angular.io/guide/browser-support.

Closes angular#45925.
@AndrewKushnir AndrewKushnir marked this pull request as ready for review May 9, 2022
@AndrewKushnir AndrewKushnir added action: merge action: merge-assistance labels May 9, 2022
@ngbot
Copy link

@ngbot ngbot bot commented May 9, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: aio_preview" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir
Copy link
Contributor Author

@AndrewKushnir AndrewKushnir commented May 9, 2022

Merge-assistance: the aio_preview failures are pre-existing.

@AndrewKushnir
Copy link
Contributor Author

@AndrewKushnir AndrewKushnir commented May 9, 2022

This PR was merged into the repository by commit af253cc.

AndrewKushnir added a commit that referenced this issue May 9, 2022
@AndrewKushnir
ci: enable Android 12 for tests on CI (#45926)
ac7f046 
This commit updates SauceLabs config to use Android 12 and drop Android 10, so we maintain 2 most recent versions according to https://angular.io/guide/browser-support.

Closes #45925.

PR Close #45926
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jun 9, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion

Assignees
No one assigned
Labels
action: merge action: merge-assistance comp: build & ci target: rc
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrewKushnir @devversion