fix(animations): reset the start and done fns on player reset #46364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicajaniuk
added
the
target: patch
dario-piotrowicz
force-pushed
the
animations-reset-fns
branch
from
17855e0
to
e91584a
Compare
dario-piotrowicz
changed the title
in the animation players, make sure than upon reset the _onStartFns and _onDoneFns are also re-applied so that they can be called again after resetting the animation also set the noop animation player's _finished to false when the player resets (needed to make sure that the _onDoneFns get called) resolves angular#26630
update aio-local main payload
dario-piotrowicz
force-pushed
the
animations-reset-fns
branch
from
ce878e6
to
ba1c0c8
Compare
jessicajaniuk
approved these changes
Jun 21, 2022
LGTM
This looks great, @dario-piotrowicz! Thank you!
reviewed-for: fw-animations, fw-core, size-tracking
|
This PR was merged into the repository by commit 342effe. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 21, 2022
in the animation players, make sure than upon reset the _onStartFns and _onDoneFns are also re-applied so that they can be called again after resetting the animation also set the noop animation player's _finished to false when the player resets (needed to make sure that the _onDoneFns get called) resolves #26630 PR Close #46364
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jun 28, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.2/14.0.3) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.2/14.0.3) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.2/14.0.3) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.2/14.0.3) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.2/14.0.3) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.2/14.0.3) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.2/14.0.3) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.2/14.0.3) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.0.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1403-2022-06-22) [Compare Source](angular/angular@14.0.2...14.0.3) ##### animations | Commit | Type | Description | | -- | -- | -- | | [3dd7bb3f8f](angular/angular@3dd7bb3) | fix | reset the start and done fns on player reset ([#​46364](angular/angular#46364)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [c086653655](angular/angular@c086653) | fix | deduplicate imports of standalone components in JIT compiler ([#​46439](angular/angular#46439)) | | [5d3b97e1f8](angular/angular@5d3b97e) | fix | handle NgModules with standalone pipes in TestBed correctly ([#​46407](angular/angular#46407)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [6ad7b40a6f](angular/angular@6ad7b40) | fix | invalid style attribute being generated for null values ([#​46433](angular/angular#46433)) | #### Special Thanks 4javier, Aakash, Alan Agius, Andrew Kushnir, Aristeidis Bampakos, Dany Paredes, Derek Cormier, JoostK, Kristiyan Kostadinov, Paul Gschwendtner, Ramesh Thiruchelvam, behrooz bozorg chami, dario-piotrowicz, markostanimirovic, renovate\[bot] and web-dave <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1431 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
in the animation players, make sure than upon reset the
_onStartFns and _onDoneFns are also re-applied so that
they can be called again after resetting the animation
also set the noop animation player's _finished to false
when the player resets (needed to make sure that the _onDoneFns
get called)
resolves #26630
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #26630
Animations created with the animationBuilder only trigger the start and done callbacks once
For example:
What is the new behavior?
The animation re-trigger the callbacks if the animation has been reset
For example:
Does this PR introduce a breaking change?