Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] move compiler warnings/errors to dedicate files #6503

Merged

Conversation

Copy link
Member

@dummdidumm dummdidumm commented Jul 7, 2021

This organizes all compiler errors and warnings into separate files. This should help discoverability of those and know where to look them up in a distinct place. It also reduced some duplication.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@@ -21,6 +21,9 @@
"resolveJsonModule": true,
"allowSyntheticDefaultImports": true,

// Hides exports flagged with @internal from the d.ts output
"stripInternal": true,
Copy link
Member Author

@dummdidumm dummdidumm Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should help us not leaking internal API

@dummdidumm dummdidumm merged commit b662c7f into sveltejs:master Jul 7, 2021
16 checks passed
@dummdidumm dummdidumm deleted the compiler-warnings-structuring branch Jul 7, 2021
@dummdidumm dummdidumm mentioned this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant