-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix yamlloader.DuplicateKeyWarning leaking #62021
Conversation
`yamlloader.DuplicateKeyWarning` leaks through the external `warnings` module, every time `LazyLoader` loads the `yamlloader` module, `yamlloader` adds a new `DuplicateKeyWarning` class (with new address and hash) to the internal list of warnings of the `warnings` module. After this PR#8589 the code about adding warnings is dead code, so just delete it.
Hi, please tell me who will merge it, I can't do it myself. |
@dmurphy18 I don't have the right to merge it, can you merge? |
@sakateka I don't have merge rights either, but just re-reviewing this, QQ is the change already covered by existing tests ?, if not, it should have a test to show the fix is working. |
This is just removing dead code, there is no impact on existing code. |
Updated PR with current master branch and re-running tests, if no fails will push to get it in - got to fix those leaks |
!merge |
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.24s - exit code: 1 Thanks again! |
re-run pr-ubuntu-2204-amd64-py3-m2crypto-pytest |
yamlloader.DuplicateKeyWarning
leaks through the externalwarnings
module,every time
LazyLoader
loads theyamlloader
module,yamlloader
adds a newDuplicateKeyWarning
class (with new address and hash)to the internal list of warnings of the
warnings
module.After this #8589 the code about adding warnings is dead code, so just delete it.
What does this PR do?
Fixing memory leak in
yamlloader
andyamlloader_old
modules.What issues does this PR fix or reference?
Fixes:
may be #61988
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.