Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: groupby().rolling(freq) with monotonic dates within groups #46065 #46567

Merged
merged 6 commits into from Mar 31, 2022
Merged

BUG: groupby().rolling(freq) with monotonic dates within groups #46065 #46567

merged 6 commits into from Mar 31, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Mar 30, 2022 •
edited

  • closes #46061 (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/v1.4.2.rst file if fixing a bug or adding a new feature.

Restored version in #46065 as there is some support for the bug fix despite the performance hit.

@mroeschke mroeschke added Bug Window labels Mar 30, 2022
@mroeschke mroeschke added this to the 1.4.2 milestone Mar 30, 2022
@jreback jreback merged commit d2aa44f into pandas-dev:main Mar 31, 2022
37 checks passed
@jreback
Copy link

@jreback jreback commented Mar 31, 2022

@meeseeksdev backport 1.4.x

@meeseeksdev

This comment has been hidden.

Sign in to view
@meeseeksdev

This comment has been hidden.

Sign in to view
@mroeschke mroeschke deleted the bug/gb_roll_mon branch Mar 31, 2022
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this issue Apr 1, 2022
@mroeschke @simonjayhawkins
BUG: groupby().rolling(freq) with monotonic dates within groups panda…
8469157 
…s-dev#46065  (pandas-dev#46567)

(cherry picked from commit d2aa44f)
@simonjayhawkins simonjayhawkins mentioned this pull request Apr 1, 2022
Merged
simonjayhawkins added a commit that referenced this issue Apr 1, 2022
@simonjayhawkins @mroeschke
Backport PR #46567 on branch 1.4.x (BUG: groupby().rolling(freq) with…
9c6d84c 
… monotonic dates within groups #46065 ) (#46592)

* ENH: Improve error message when rolling over NaT value (#46087)

* BUG: groupby().rolling(freq) with monotonic dates within groups #46065  (#46567)

(cherry picked from commit d2aa44f)

Co-authored-by: Matthew Roeschke <emailformattr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Window
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

BUG: groupby().rolling("freq") validation raises even if dates are sorted within each group
3 participants
@mroeschke @jreback @simonjayhawkins