Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34977: Add Windows App Store package #11027

Merged
merged 6 commits into from Dec 11, 2018
Merged

bpo-34977: Add Windows App Store package #11027

merged 6 commits into from Dec 11, 2018

Conversation

zooba
Copy link
Member

@zooba zooba commented Dec 7, 2018 •
edited by bedevere-bot

Restores the original commit, plus the fix to ensure that when building on machines without recent MSVC/WinSDK we don't fail.

https://bugs.python.org/issue34977

@zooba zooba requested a review from as a code owner Dec 7, 2018
vstinner
vstinner previously requested changes Dec 7, 2018
View changes
Copy link
Member

@vstinner vstinner left a comment

Please move the venv and tests change into a separated PR.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 7, 2018

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

vstinner
vstinner reviewed Dec 7, 2018
View changes
PC/launcher.c Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

@vstinner vstinner commented Dec 7, 2018

Please run a custom build on buildbot before merging this PR, I would prefer to not have to revert the change one more time :-)
https://bugs.python.org/issue34977#msg331322

@zooba
Copy link
Member Author

@zooba zooba commented Dec 7, 2018

How do you trigger a custom build these days? I couldn't find the UI.

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 7, 2018

How do you trigger a custom build these days? I couldn't find the UI.

It's basically just a Git push to the right branch:

$ git push upstream <local_branch_name>:buildbot-custom

See https://devguide.python.org/buildbots/#custom-builders for more info.

Then you can go to https://buildbot.python.org/all/#/builders for example to see results: check the custom workers ran your job and check that they are green ;-) You should ignore unstable buildbots like Alpine or Clang UBSan custom. Well, we mostly care about Windows here :-)

@zooba zooba mentioned this pull request Dec 7, 2018
Merged
zooba added a commit to zooba/cpython that referenced this issue Dec 10, 2018
@zooba
bpo-34977: Add Windows App Store package (pythonGH-11027)
c5718e5
@zooba
Copy link
Member Author

@zooba zooba commented Dec 10, 2018

I have made the requested changes; please review again

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 10, 2018

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

pfmoore
pfmoore approved these changes Dec 10, 2018
View changes
Copy link
Member

@pfmoore pfmoore left a comment

A couple of minor points, but generally this looks OK to me.

Doc/using/windows.rst Outdated Show resolved Hide resolved
Doc/using/windows.rst Outdated Show resolved Hide resolved
@zooba zooba dismissed vstinner’s stale review Dec 11, 2018

Outdated

@zooba zooba merged commit 0cd6391 into python:master Dec 11, 2018
5 checks passed
@zooba zooba deleted the bpo34977 branch Dec 11, 2018
zooba added a commit that referenced this issue Dec 11, 2018
@zooba
bpo-34977: Add Windows App Store package (GH-11027)
0e4ad88 
Also adds the PC/layout script for generating layouts on Windows.
@saschanaz saschanaz mentioned this pull request May 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@pfmoore pfmoore

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zooba @bedevere-bot @vstinner @pfmoore @the-knights-who-say-ni