GH-94163: Add BINARY_SLICE and STORE_SLICE instructions. #94168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markshannon
commented
Jun 23, 2022
•
- Issue: gh-94163
|
Pyperformance shows a nominally slowdown, but in the noise. |
|
The dis doc update is missing. |
iritkatriel
reviewed
Jun 24, 2022
| @@ -479,6 +479,20 @@ the original TOS1. | |||
| Implements ``del TOS1[TOS]``. | |||
|
|
|||
|
|
|||
| .. opcode:: BINARY_SLICE | |||
|
|
|||
| Implements ``TOS = TOS2[TOS1:TOS]``. | |||
There was a problem hiding this comment.
I think the preamble to this section in lines 449-456 needs to be updated because it only refers to TOS and TOS1.
| @@ -13,6 +13,8 @@ extern "C" { | |||
|
|
|||
| extern void _PySlice_Fini(PyInterpreterState *); | |||
|
|
|||
| extern PyObject * | |||
| _PyBuildSlice_Consume2(PyObject *start, PyObject *stop); | |||
There was a problem hiding this comment.
Consume here refers to references of start and stop? Can it be more explicit, maybe _PyBuildSlice_ConsumeRefs?
kumaraditya303
reviewed
Jun 24, 2022
| @@ -0,0 +1,3 @@ | |||
| Add BINARY_SLICE and STORE_SLICE instructions for more efficient handling | |||
There was a problem hiding this comment.
Suggested change
| Add BINARY_SLICE and STORE_SLICE instructions for more efficient handling | |
| Add :opcode:`BINARY_SLICE` and :opcode:`STORE_SLICE` instructions for more efficient handling |
iritkatriel
approved these changes
Jun 24, 2022
markshannon
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
|
Failures on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.