Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD: make tests discoverable in .devcontainer.json #34929

Merged
merged 2 commits into from Jun 23, 2020
Merged

BUILD: make tests discoverable in .devcontainer.json #34929

merged 2 commits into from Jun 23, 2020

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jun 22, 2020 •
edited

I wasn't able to discover tests using the current setup, I had to use "python.testing.pytestArgs" instead of "python.testing.cwd"

@MarcoGorelli MarcoGorelli marked this pull request as draft Jun 22, 2020
@MarcoGorelli MarcoGorelli marked this pull request as ready for review Jun 22, 2020
WillAyd
WillAyd approved these changes Jun 22, 2020
View changes
Copy link
Member

@WillAyd WillAyd left a comment

lgtm

@WillAyd WillAyd added the Build label Jun 22, 2020
@WillAyd WillAyd added this to the 1.1 milestone Jun 22, 2020
@WillAyd WillAyd merged commit d8c2ab5 into pandas-dev:master Jun 23, 2020
14 checks passed
@WillAyd
Copy link
Member

@WillAyd WillAyd commented Jun 23, 2020

Thanks @MarcoGorelli

@MarcoGorelli MarcoGorelli deleted the make-tests-discoverable branch Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcoGorelli @WillAyd