Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added link to advanced indexing guide in .loc docstring #47520

Merged
merged 2 commits into from Jun 28, 2022

Conversation

INDIG0N
Copy link
Contributor

@INDIG0N INDIG0N commented Jun 27, 2022

closes #46620
Not sure if the online documentation also needs to change with this docstring.
if it does, how can I change that?

@pep8speaks
Copy link

@pep8speaks pep8speaks commented Jun 27, 2022

Hello @INDIG0N! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-06-27 22:50:54 UTC


For more details and explanations on advanced indexing,
please visit the following link:
https://pandas.pydata.org/docs/user_guide/advanced.html#advanced-indexing-with-hierarchical-index
Copy link
Member

@mroeschke mroeschke Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use a sphinx style reference like

Please see the :ref:`user guide<advanced.advanced_hierarchical>` for more details and explanations of advanced indexing.

Copy link
Contributor Author

@INDIG0N INDIG0N Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I went ahead and pushed the change to my repo

@mroeschke mroeschke added the Docs label Jun 28, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jun 28, 2022
@mroeschke mroeschke merged commit 2fc7fab into pandas-dev:main Jun 28, 2022
33 of 34 checks passed
@mroeschke
Copy link
Member

@mroeschke mroeschke commented Jun 28, 2022

Thanks @INDIG0N

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants