gh-93243: Make smtpd private before porting its users #93246
Conversation
Misc/NEWS.d/next/Library/2022-05-26-08-41-34.gh-issue-93243.uw6x5z.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
cc also PEP-594 co-author @brettcannon. |
Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.
| with warnings.catch_warnings(): | ||
| from . import smtpd |
There was a problem hiding this comment.
If smptd is being moved for internal use of testing then there shouldn't be any need to have it raise warnings.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
gh-93243