Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40670: More reliable validation of statements in timeit.Timer. #22358

Merged
merged 2 commits into from Sep 22, 2020

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 22, 2020

It now accepts "empty" statements (only whitespaces and comments)
and rejects misindentent statements.

https://bugs.python.org/issue40670

It now accepts "empty" statements (only whitespaces and comments)
and rejects misindentent statements.
Copy link
Member

@vstinner vstinner left a comment

LGTM but there is a typo in the NEWS entry and the commit title ;-)

Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka serhiy-storchaka changed the title bpo-40670: More reliable validation of statements in timit.Timer. bpo-40670: More reliable validation of statements in timeit.Timer. Sep 22, 2020
Copy link
Member

@vstinner vstinner left a comment

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 557b9a5 into python:master Sep 22, 2020
3 checks passed
@serhiy-storchaka serhiy-storchaka deleted the timeit-check-smtp branch Sep 22, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
…ythonGH-22358)

It now accepts "empty" statements (only whitespaces and comments)
and rejects misindentent statements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants