Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93010: InvalidHeaderError used but nonexistent #93015

Merged
merged 8 commits into from May 23, 2022
Merged

gh-93010: InvalidHeaderError used but nonexistent #93015

merged 8 commits into from May 23, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 20, 2022 •
edited by ghost

Issue #93010.

On line 2382 in Lib/email/_header_value_parser.py, errors.InvalidHeaderDefect should be used, not errors.InvalidHeaderError.

I think this requires a backport. The commit for Line 2382 was in June, 2012.

@ghost ghost self-requested a review as a code owner May 20, 2022
@bedevere-bot
Copy link

bedevere-bot commented May 20, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost ghost changed the title gh-93010: gh-93010: InvalidHeaderError used but nonexistent May 20, 2022
@ghost ghost changed the title gh-93010: InvalidHeaderError used but nonexistent gh-93010: InvalidHeaderError used but nonexistent May 20, 2022
@The-Compiler
Copy link
Contributor

The-Compiler commented May 20, 2022

Thanks for the quick fix! 👍 Perhaps it would make sense to add my reproducer from the issue as a test case as well?

@ghost
Copy link
Author

ghost commented May 20, 2022

@The-Compiler Sure!

@bedevere-bot
Copy link

bedevere-bot commented May 20, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

warsaw
warsaw requested changes May 20, 2022
View changes
Copy link
Member

@warsaw warsaw left a comment

Nice find, and thanks for the fix. I have a couple of small suggestions, and yes we should backport this to actively maintained branches.

Misc/NEWS.d/next/Library/2022-05-20-15-52-43.gh-issue-93010.WF-cAc.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented May 20, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

warsaw
warsaw reviewed May 20, 2022
View changes
Lib/test/test_email/test_email.py Outdated Show resolved Hide resolved
warsaw
warsaw reviewed May 20, 2022
View changes
Lib/test/test_email/test_email.py Outdated Show resolved Hide resolved
@warsaw warsaw self-assigned this May 20, 2022
warsaw
warsaw reviewed May 20, 2022
View changes
Lib/test/test_email/test_email.py Outdated Show resolved Hide resolved
@ghost ghost requested a review from warsaw May 20, 2022
@ghost
Copy link
Author

ghost commented May 20, 2022

As instructed by bedevere: I have made the requested changes; please review again. Thank you!

@bedevere-bot
Copy link

bedevere-bot commented May 20, 2022

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

warsaw
warsaw requested changes May 21, 2022
View changes
Lib/test/test_email/test_email.py Show resolved Hide resolved
Lib/test/test_email/test_email.py Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented May 21, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

warsaw
warsaw approved these changes May 23, 2022
View changes
@warsaw warsaw merged commit 71abeb0 into python:main May 23, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 23, 2022

Thanks @oda-gitso for the PR, and @warsaw for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2022
@miss-islington
pythongh-93010: InvalidHeaderError used but nonexistent (pythonGH-93015)
fdd2cc2 
* fix issue 93010

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 71abeb0)

Co-authored-by: oda-gitso <105083118+oda-gitso@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented May 23, 2022

GH-93131 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2022
@miss-islington
pythongh-93010: InvalidHeaderError used but nonexistent (pythonGH-93015)
a913bad 
* fix issue 93010

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 71abeb0)

Co-authored-by: oda-gitso <105083118+oda-gitso@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented May 23, 2022

GH-93132 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request May 23, 2022
@miss-islington
gh-93010: InvalidHeaderError used but nonexistent (GH-93015)
a509d26 
* fix issue 93010

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 71abeb0)

Co-authored-by: oda-gitso <105083118+oda-gitso@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 23, 2022
@miss-islington
gh-93010: InvalidHeaderError used but nonexistent (GH-93015)
b15b94d 
* fix issue 93010

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 71abeb0)

Co-authored-by: oda-gitso <105083118+oda-gitso@users.noreply.github.com>
@ghost ghost deleted the fix-issue-93010 branch May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@warsaw warsaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bedevere-bot @The-Compiler @miss-islington @warsaw @OTheDev