Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-90005: Rename MODULE_EGG variable to MODULE_EGG_STATE #94301

Merged
merged 1 commit into from Jun 27, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 26, 2022

It makes it easier to look for module states in sysconfig without
special casing suffixes "_CFLAGS", "_DEPS", "_LDFLAGS", "_OBJS",
and "CTYPES_MALLOC_CLOSURE".

Automerge-Triggered-By: GH:tiran

@tiran tiran added build needs backport to 3.11 labels Jun 26, 2022
@tiran tiran requested a review from erlend-aasland Jun 26, 2022
It makes it easier to look for module states in sysconfig without
special casing suffixes "_CFLAGS", "_DEPS", "_LDFLAGS", "_OBJS",
and "CTYPES_MALLOC_CLOSURE".
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

+1
lgtm

@tiran tiran added the 🤖 automerge label Jun 27, 2022
@miss-islington miss-islington merged commit 71868a0 into python:main Jun 27, 2022
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 27, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 27, 2022

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 71868a0066a90519ccc6aeb75673ae882aaa03f0 3.11

@miss-islington miss-islington self-assigned this Jun 27, 2022
@tiran tiran deleted the gh-90005-state branch Jun 27, 2022
tiran added a commit to tiran/cpython that referenced this issue Jun 27, 2022
…pythonGH-94301)

It makes it easier to look for module states in sysconfig without
special casing suffixes "_CFLAGS", "_DEPS", "_LDFLAGS", "_OBJS",
and "CTYPES_MALLOC_CLOSURE"..
(cherry picked from commit 71868a0)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 27, 2022

GH-94317 is a backport of this pull request to the 3.11 branch.

tiran added a commit that referenced this issue Jun 27, 2022
…4301) (GH-94317)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🤖 automerge skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants