[3.11] [Enum] store members in class dict; comment out tests #94392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfurman
commented
Jun 30, 2022
| @@ -648,6 +648,10 @@ def __new__(metacls, cls, bases, classdict, *, boundary=None, _simple=False, **k | |||
| % (enum_class._member_names_, _order_) | |||
| ) | |||
| # | |||
| # store members in class dict for performance | |||
There was a problem hiding this comment.
This is the change that matters.
ethanfurman
commented
Jun 30, 2022
| @@ -648,6 +648,10 @@ def __new__(metacls, cls, bases, classdict, *, boundary=None, _simple=False, **k | |||
| % (enum_class._member_names_, _order_) | |||
| ) | |||
| # | |||
| # store members in class dict for performance | |||
| for name, member in enum_class._member_map_.items(): | |||
There was a problem hiding this comment.
Below changes are a different project, but have no bearing on the tests.
|
Pyperformance benchmark results Basically "same", which isn't surprising, given that none of the benchmarks spend significant time in enums. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.