Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94393: Remove unneeded module state from _json #94394

Merged
merged 2 commits into from Jul 2, 2022
Merged

gh-94393: Remove unneeded module state from _json #94394

merged 2 commits into from Jul 2, 2022
+15 −58

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 28, 2022 •
edited by bedevere-bot

@erlend-aasland erlend-aasland linked an issue Jun 28, 2022 that may be closed by this pull request
Remove unneeded module state from _json module #94393
Closed
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jun 28, 2022

Also simplify ref.counting by using modern C API for adding the type objects.

@erlend-aasland erlend-aasland mentioned this pull request Jun 28, 2022
Closed
encukou
encukou reviewed Jun 29, 2022
View changes
Modules/_json.c Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland requested a review from encukou Jun 29, 2022
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jul 1, 2022

FYI, I'll merge this in a couple of days.

corona10
corona10 approved these changes Jul 2, 2022
View changes
Copy link
Member

@corona10 corona10 left a comment

lgtm please go ahead.

@erlend-aasland erlend-aasland merged commit 3a2e615 into python:main Jul 2, 2022
12 checks passed
@erlend-aasland erlend-aasland deleted the remove-unneeded-state-from-json branch Jul 2, 2022
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jul 2, 2022

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@shihai1991 shihai1991

@encukou encukou

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unneeded module state from _json module
4 participants
@erlend-aasland @encukou @corona10 @bedevere-bot