Skip to content

gh-94332: make it safe to call assemble_free when assemble_init has not been called #94389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2022
Merged

gh-94332: make it safe to call assemble_free when assemble_init has not been called #94389

merged 1 commit into from
Jun 30, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 28, 2022 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel requested a review from markshannon as a code owner June 28, 2022 14:38
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error type-crash A hard crash of the interpreter, possibly with a core dump labels Jun 30, 2022
@iritkatriel iritkatriel merged commit be82d26 into python:main Jun 30, 2022
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker be82d26570343dafc8a89be5a1a0e2f58d51a904 3.11

@miss-islington
Copy link
Contributor

Sorry @iritkatriel, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker be82d26570343dafc8a89be5a1a0e2f58d51a904 3.10

iritkatriel added a commit that referenced this pull request Jun 30, 2022
@iritkatriel
gh-94332: make it safe to call assemble_free when assemble_init has n…
27f6601 
…ot been called (GH-94389)

(cherry picked from commit be82d26)
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 30, 2022
@bedevere-bot
Copy link

GH-94442 is a backport of this pull request to the 3.11 branch.

iritkatriel added a commit that referenced this pull request Jun 30, 2022
@iritkatriel
gh-94332: make it safe to call assemble_free when assemble_init has n…
3fadf2e 
…ot been called (GH-94389)

(cherry picked from commit be82d26)
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 30, 2022
@bedevere-bot
Copy link

GH-94443 is a backport of this pull request to the 3.10 branch.

iritkatriel added a commit that referenced this pull request Jun 30, 2022
@iritkatriel
gh-94332: make it safe to call assemble_free when assemble_init has n…
48a739e 
…ot been called (GH-94389) (GH-94442)

(cherry picked from commit be82d26)
iritkatriel added a commit that referenced this pull request Jun 30, 2022
@iritkatriel
gh-94332: make it safe to call assemble_free when assemble_init has n…
1e6c678 
…ot been called (GH-94389) (GH-94443)

(cherry picked from commit be82d26)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
@iritkatriel @gvanrossum
pythongh-94332: make it safe to call assemble_free when assemble_init…
b966d66 
… has not been called (pythonGH-94389)
@iritkatriel iritkatriel deleted the gh-94332 branch July 25, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

Assignees

@iritkatriel iritkatriel

Labels
skip news type-bug An unexpected behavior, bug, or error type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iritkatriel @miss-islington @bedevere-bot @markshannon