Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate sqlite3.version and sqlite3.version_info #93370

Closed
erlend-aasland opened this issue May 31, 2022 · 6 comments · Fixed by #93482
Closed

Deprecate sqlite3.version and sqlite3.version_info #93370

erlend-aasland opened this issue May 31, 2022 · 6 comments · Fixed by #93482
Labels
3.12 easy expert-sqlite3 type-feature

Comments

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 31, 2022 •
edited

The sqlite3.version and sqlite3.version_info attributes have historically created some confusion, as they are sometimes mistaken for the SQLite 3 version number. They used to reflect the pysqlite1 version number, until the external pysqlite package stopped upstreaming changes to the stdlib sqlite3 module2, but today they carry no meaning or practical value3.

In order to avoid future frustration, I suggest to deprecate sqlite3.version and sqlite3.version_info in 3.12, and remove them in 3.14.

See also discussion on Discourse

Footnotes

  1. The sqlite3 stdlib module was forked off of the external pysqlite module around 2005. ↩

  2. Somewhere around 2015, IIRC. ↩

  3. sqlite3.version is set to the value '2.6.0', and sqlite3.version_info is set to the value (2, 6, 0). ↩
@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 31, 2022

But it would be nice to expose the Sqlite 3 version number. What do you think?

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jun 1, 2022 •
edited

But it would be nice to expose the Sqlite 3 version number. What do you think?

We already do :) sqlite3.sqlite_version and sqlite3.sqlite_version_info

@subramaniam02
Copy link

@subramaniam02 subramaniam02 commented Jun 3, 2022

Not sure what is the process. But I am interested to work on this.

@rawwar rawwar mentioned this issue Jun 3, 2022
Merged
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jun 5, 2022

Not sure what is the process. But I am interested to work on this.

Sorry for the late reply. Looks like there is already a PR up, however there are probably more deprecations coming up in the 3.12 dev phase :)

@subramaniam02
Copy link

@subramaniam02 subramaniam02 commented Jun 6, 2022

Not sure what is the process. But I am interested to work on this.

Sorry for the late reply. Looks like there is already a PR up, however there are probably more deprecations coming up in the 3.12 dev phase :)

Ok Thank you !

erlend-aasland added a commit that referenced this issue Jun 7, 2022
@rawwar @AlexWaygood
@AA-Turner @erlend-aasland
gh-93370: Deprecate sqlite3.version and sqlite3.version_info (#93482)
ffc58a9 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland linked a pull request Jun 7, 2022 that will close this issue
gh-93370 : Deprecate sqlite3.version and sqlite3.version_info #93482
Merged
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jun 7, 2022

Resolved with #93482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 easy expert-sqlite3 type-feature
Projects
sqlite3 issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-93370 : Deprecate sqlite3.version and sqlite3.version_info rawwar/cpython
3 participants
@subramaniam02 @serhiy-storchaka @erlend-aasland