Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90473: Make chmod a dummy on WASI, skip chmod tests #93534

Merged
merged 1 commit into from Jun 6, 2022
Merged

gh-90473: Make chmod a dummy on WASI, skip chmod tests #93534

merged 1 commit into from Jun 6, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 6, 2022

WASI does not have chmod(2) syscall yet.

@tiran
pythongh-90473: Make chmod a dummy on WASI, skip chmod tests
eae6042 
WASI does not have ``chmod(2)`` syscall yet.
carlbordum
carlbordum approved these changes Jun 6, 2022
View changes
Copy link
Contributor

@carlbordum carlbordum left a comment

LGTM

Lib/test/test_argparse.py Show resolved Hide resolved
@ambv ambv merged commit 22fed60 into python:main Jun 6, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 6, 2022

Thanks @tiran for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 6, 2022
@tiran @miss-islington
pythongh-90473: Make chmod a dummy on WASI, skip chmod tests (pythonG…
ca7b0d0 
…H-93534)

WASI does not have the ``chmod(2)`` syscall yet.
(cherry picked from commit 22fed60)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 6, 2022

GH-93550 is a backport of this pull request to the 3.11 branch.

ambv pushed a commit that referenced this issue Jun 6, 2022
@miss-islington @tiran
gh-90473: Make chmod a dummy on WASI, skip chmod tests (GH-93534) (GH…
6787a8f 
…-93550)

WASI does not have the ``chmod(2)`` syscall yet.
(cherry picked from commit 22fed60)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbordum carlbordum

@brettcannon brettcannon

@ethanfurman ethanfurman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tiran @miss-islington @bedevere-bot @carlbordum @ambv