GH-93533: Shrink the LOAD_METHOD cache by one codeunit. #93537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
changed the title
Fidget-Spinner
approved these changes
Jun 6, 2022
LGTM. Anyways this can be specialized with the future LOAD_ATTR anyways, it just won't have the bound method optimization.
|
What won't have the bound method optimization, and why? |
Descriptors with Edit: |
Fidget-Spinner
reviewed
Jun 7, 2022
| @@ -4581,12 +4581,9 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, _PyInterpreterFrame *frame, int | |||
| DEOPT_IF(self_cls->tp_version_tag != read_u32(cache->type_version), | |||
| LOAD_METHOD); | |||
| /* Treat index as a signed 16 bit value */ | |||
| int dictoffset = *(int16_t *)&cache->dict_offset; | |||
| int dictoffset = self_cls->tp_dictoffset; | |||
There was a problem hiding this comment.
I just realised this warns on MSVC. It seems that this dictoffset and the one below needs to be Py_ssize_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#93533
Remove the
dict_offsetcache entry.See faster-cpython/ideas#396
The
LOAD_METHOD_WITH_DICTis largely ineffective for objects with managed dictionaries, so we don't specialize for that case.