Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-90005: Port _ctypes to PY_STDLIB_MOD #32229

Merged
merged 13 commits into from Jun 26, 2022
Merged

Conversation

tiran
Copy link
Member

@tiran tiran commented Apr 1, 2022

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue45847

Automerge-Triggered-By: GH:tiran

@arhadthedev
Copy link
Contributor

@arhadthedev arhadthedev commented Apr 1, 2022

Is is a harbinger of finally devendored libffi? Currently, CPython ships 1.20 (1998) while Debian LTS supplies 3.2.1 (2014).

@tiran
Copy link
Member Author

@tiran tiran commented Apr 1, 2022

libffi was de-vendored in 3.7 (Linux, BSD) and 3.8 (Windows). We only keep a copy for macos around.

@tiran tiran added the 🔨 test-with-buildbots label Apr 1, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 1, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit cc5cb24 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 1, 2022
@tiran
Copy link
Member Author

@tiran tiran commented Apr 1, 2022

ctypes tests are failing on ARM64 macOS

@tiran
Copy link
Member Author

@tiran tiran commented Apr 1, 2022

I have no clue how the SDK stuff works on macOS. In order to land the PR I would need some assistance from @ned-deily or @ronaldoussoren . Or can we drop the SDK and use system-ffi on all system?

@tiran tiran added the 🔨 test-with-buildbots label Apr 1, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 1, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 54e6b11 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 1, 2022
@ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Apr 1, 2022

I'll try to look at the PR over the weekend.

As a general statement I'd prefer to use the system install of libffi on macOS because Apple includes some magic in its version to ensure libffi closures work properly with their code signature system (in particular some magic to ensure that you don't need the "JIT" entitlement to use closures).

@tiran tiran added the 🔨 test-with-buildbots label Apr 2, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 2, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 53607e3 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 2, 2022
@tiran tiran added the 🔨 test-with-buildbots label Apr 3, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 3, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit e4ab8cf 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 3, 2022
@tiran tiran marked this pull request as ready for review Apr 4, 2022
@tiran
Copy link
Member Author

@tiran tiran commented Jun 22, 2022

Users without pkg-config can fall back to LIBFFI_CFLAGS and LIBFFI_LIBS env vars, too.

@tiran tiran added the 🔨 test-with-buildbots label Jun 26, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 26, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit d854d7f 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Jun 26, 2022
@tiran
Copy link
Member Author

@tiran tiran commented Jun 26, 2022

@ned-deily @ronaldoussoren I would like to merge this PR rather sooner than later into main. It is required to test ctypes on wasm32-emscripten and will allow us to remove setup.py. Tests are passing on macOS.

configure.ac Outdated Show resolved Hide resolved
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@tiran tiran added the 🤖 automerge label Jun 26, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 26, 2022

Status check is done, and it's a success .

@miss-islington miss-islington merged commit bb8b931 into python:main Jun 26, 2022
14 checks passed
@tiran tiran deleted the bpo-45847-ctypes2 branch Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed 🤖 automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants