Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean up. #25488

Closed
wants to merge 3 commits into from
Closed

Minor clean up. #25488

wants to merge 3 commits into from

Conversation

10maurycy10
Copy link

@10maurycy10 10maurycy10 commented Apr 20, 2021

Not much to say here.

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Apr 20, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@10maurycy10

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@pablogsal
Copy link
Member

pablogsal commented Apr 20, 2021

Hi @10maurycy10 and thanks for the PR. A couple of things:

  • You need to make sure to sign the CLA before contributing to Python. Check the previous comment.
  • I don't understand what this PR is cleaning. Normally we don't refactor code for formatting or similar purposes unfortunately.

@10maurycy10
Copy link
Author

10maurycy10 commented Apr 20, 2021

It fixes some missing brackets that looks out of place.

@pablogsal
Copy link
Member

pablogsal commented Apr 20, 2021

It fixes some missing brackets that looks out of place.

Unfortunately we normally don't take PRs that are formatting only to avoid risking introducing subtle bugs. I am going to close this PR but I am sure you will find something interesting to work on! :)

P.S. Make sure to sign up the CLA so we can review your future work !

@pablogsal pablogsal closed this Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants