New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete DOS-only PC/testpy.py #94419
Delete DOS-only PC/testpy.py #94419
Conversation
arm and win32 report
which doesn't seem related but it would still be better to have everything green to check in a file deletion. Let me update the branch. |
OK, this is now passing. I'll leave this PR open for the next day or so, maybe @zooba has a comment before we remove the file. |
This is fine, but are there any other files to be removed from the PC directory? No point doing a single PR for each one if they're this uncontroversial. |
There are files mentioned nowhere in python/cpython (
The only thing I know is that the following files must be kept:
JFYI, the list is generated with from os.path import basename
from subprocess import run
from sys import stderr
lstree = ('git', 'ls-tree', '-r', '--name-only', 'HEAD')
lstree_result = run(lstree, capture_output=True, check=True, text=True)
tracked_files = lstree_result.stdout.splitlines()
for file_path in tracked_files:
print(file_path, file=stderr)
file_name = basename(file_path)
grep_result = run(['git', 'grep', '-q', file_name, '--', ':/'])
found_no_usage = grep_result.returncode != 0
if found_no_usage:
print(f'- {file_path}') |
@pablogsal Are |
You need to fix that script, because those files are definitely used ;-) The *.icns ones are the macOS versions of those icons, which we kept for the day that the icons are aligned between releases. They're probably genuinely not referenced anywhere. All the rest are part of the PC/layout script, and are essential. So this tells me there's nothing left to clean up and I can merge this PR, thanks! |
On Windows,
python PC\testpy.py
prints the following error:According to the script source code, it would then call
test.libregrtest.main
. However, we have a dedicatedpython -m test
runner with lots of parameters for such a purpose.