feat(core): add ability to set inputs on ComponentRef #46641
Conversation
|
@pkozlowski-opensource Great news, thank you. |
This change adds the setInput method to the ComponentRef. This has two benefits: - it takes input aliasing into account - it marks OnPush components as dirty - it triggers NgOnChanges lifecycle hook Closes angular#12313 Closes angular#22567
pkozlowski-opensource
force-pushed
the
fixit_set_input
branch
from
948c4ad
to
7019681
Compare
pkozlowski-opensource
added
the
target: minor
This is exciting! I think it would be worth mentioning some more about why in the commit message, not just the what. For example, how this affects testing for components with inputs, how this makes working with dynamic component creation easier (not having to manually call ngOnChanges in code, for example), and the potential for unlocking other features such as binding route params to component inputs.
| * component using the `OnPush` change detection strategy. It will trigger execution of the | ||
| * `OnChanges` lifecycle hook. |
There was a problem hiding this comment.
As mentioned in the chat, I think we should be more clear about the statement "it will trigger execution of the OnChanges lifecycle hook. This feels like it's implying ngOnChanges will run immediately but that's not true. It gets run as part of the next change detection.
This change adds the setInput method to the ComponentRef with the following benefits:
Closes #12313
Closes #22567