Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fromEntries.js #3809

Merged
merged 2 commits into from Jun 1, 2018
Merged

Create fromEntries.js #3809

merged 2 commits into from Jun 1, 2018

Conversation

ycmjason
Copy link
Contributor

@ycmjason ycmjason commented Jun 1, 2018

this acts as an alias for _.fromPairs since entries seem to be the official name for those pairs. (Object.entries)

this acts as an alias for `_.fromPairs` since entries seem to be the official name for those pairs. (`Object.entries`)
@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Jun 1, 2018

CLA assistant check
All committers have signed the CLA.

@jdalton
Copy link
Member

@jdalton jdalton commented Jun 1, 2018

For v5 we'll likely just rename it to the official name. If you'd like to modify the PR to do that, that would be rad.

@ycmjason
Copy link
Contributor Author

@ycmjason ycmjason commented Jun 1, 2018

@jdalton should I keep _.fromPairs as an alias?

@jdalton
Copy link
Member

@jdalton jdalton commented Jun 1, 2018

You can drop fromPairs.

Update:

Thanks @ycmjason!

@jdalton jdalton merged commit b8dfb7c into lodash:master Jun 1, 2018
1 of 2 checks passed
@jdalton jdalton added change and removed enhancement labels Jun 1, 2018
@lock
Copy link

@lock lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants