Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing.TypedDict documentation doesn't list minimum version for __required_keys__ and __optional_keys__ #94439

Open
finite-state-machine opened this issue Jun 30, 2022 · 0 comments
Open

typing.TypedDict documentation doesn't list minimum version for __required_keys__ and __optional_keys__ #94439

finite-state-machine opened this issue Jun 30, 2022 · 0 comments
Labels
docs Documentation in the Doc dir expert-typing

Comments

@finite-state-machine
Copy link

finite-state-machine commented Jun 30, 2022

Documentation

The TypeDict class exposes attributes __required_keys__ and __optional_keys__ starting in Python 3.9, but the documentation doesn't list the minimum version for these features, implying that they're available in Python 3.8.

c.f. https://github.com/python/cpython/blob/main/Doc/library/typing.rst near line 1827.
@finite-state-machine finite-state-machine added the docs Documentation in the Doc dir label Jun 30, 2022
@finite-state-machine finite-state-machine changed the title typing.TypedDict documentation doesn't list minimum version for __required_keys and __optional_keys typing.TypedDict documentation doesn't list minimum version for __required_keys and __optional_keys__ Jun 30, 2022
@finite-state-machine finite-state-machine changed the title typing.TypedDict documentation doesn't list minimum version for __required_keys and __optional_keys__ typing.TypedDict documentation doesn't list minimum version for __required_keys__ and __optional_keys__ Jun 30, 2022
@bedevere-bot bedevere-bot mentioned this issue Jul 28, 2022
Merged
@bedevere-bot bedevere-bot mentioned this issue Aug 13, 2022
Merged
JelleZijlstra pushed a commit that referenced this issue Aug 13, 2022
@howiezhao
gh-94439: typing docs: Add minimum version to __required_keys__ and…
f235178 
… `__optional_keys__` (#95373)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 13, 2022
@howiezhao @miss-islington
pythongh-94439: typing docs: Add minimum version to `__required_keys_…
f63bffc 
…_` and `__optional_keys__` (pythonGH-95373)

(cherry picked from commit f235178)

Co-authored-by: Howie Zhao <howiezhaohr@hotmail.com>
@bedevere-bot bedevere-bot mentioned this issue Aug 13, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 13, 2022
@howiezhao @miss-islington
pythongh-94439: typing docs: Add minimum version to `__required_keys_…
1e99396 
…_` and `__optional_keys__` (pythonGH-95373)

(cherry picked from commit f235178)

Co-authored-by: Howie Zhao <howiezhaohr@hotmail.com>
miss-islington added a commit that referenced this issue Aug 13, 2022
@miss-islington @howiezhao
gh-94439: typing docs: Add minimum version to __required_keys__ and…
a372a7d 
… `__optional_keys__` (GH-95373)

(cherry picked from commit f235178)

Co-authored-by: Howie Zhao <howiezhaohr@hotmail.com>
pablogsal pushed a commit that referenced this issue Aug 13, 2022
@miss-islington @howiezhao
[3.11] gh-94439: typing docs: Add minimum version to `__required_keys…
1fccb1d 
…__` and `__optional_keys__` (GH-95373) (#95944)

Co-authored-by: Howie Zhao <howiezhaohr@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir expert-typing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JelleZijlstra @finite-state-machine