Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90005-ffi: Fix building _ctypes without pkg-config (GH-94451) #94451

Merged
merged 1 commit into from Jul 1, 2022
Merged

gh-90005-ffi: Fix building _ctypes without pkg-config (GH-94451) #94451

merged 1 commit into from Jul 1, 2022
+13 −3

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 30, 2022 •
edited by bedevere-bot

The fallback path did not set LIBFFI_LIBS variable to link with
-lffi.

@tiran
pythongh-90005-ffi: Fix building _ctypes without pkg-config
87acdc1 
The fallback path did not set ``LIBFFI_LIBS`` variable to link with
``-lffi``.
@tiran tiran requested a review from erlend-aasland Jun 30, 2022
@tiran
Copy link
Member Author

@tiran tiran commented Jun 30, 2022 

$ ./configure -C --without-pkg-config
$ make
...
gcc -shared build/temp.linux-x86_64-3.12/home/heimes/dev/python/cpython/Modules/_ctypes/_ctypes.o build/temp.linux-x86_64-3.12/home/heimes/dev/python/cpython/Modules/_ctypes/callbacks.o build/temp.linux-x86_64-3.12/home/heimes/dev/python/cpython/Modules/_ctypes/callproc.o build/temp.linux-x86_64-3.12/home/heimes/dev/python/cpython/Modules/_ctypes/cfield.o build/temp.linux-x86_64-3.12/home/heimes/dev/python/cpython/Modules/_ctypes/stgdict.o -L/usr/local/lib -ldl -o build/lib.linux-x86_64-3.12/_ctypes.cpython-312-x86_64-linux-gnu.so
...
Following modules built successfully but were removed because they could not be imported:
_ctypes

@tiran tiran changed the title gh-90005-ffi: Fix building _ctypes without pkg-config gh-90005-ffi: Fix building _ctypes without pkg-config (GH-94451) Jul 1, 2022
@tiran tiran merged commit d6acdc1 into python:main Jul 1, 2022
14 checks passed
@tiran tiran deleted the gh-90005-ffi branch Jul 1, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 1, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 1, 2022

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d6acdc1b60de4f6fd05c6654a9661b7edddf0448 3.11

@tiran
Copy link
Member Author

@tiran tiran commented Jul 1, 2022

The ctypes in configure PR did not land in 3.11.

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 1, 2022

lgtm! there might be others like this... we should do an audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland

Assignees

@tiran tiran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiran @miss-islington @erlend-aasland @bedevere-bot