Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mandelbrot.py: Commenting out long running tests #5558

Merged
merged 10 commits into from Oct 23, 2021
Merged

mandelbrot.py: Commenting out long running tests #5558

merged 10 commits into from Oct 23, 2021

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 23, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews enhancement labels Oct 23, 2021
@cclauss cclauss requested review from onlinejudge95 and poyea Oct 23, 2021
poyea
poyea approved these changes Oct 23, 2021
View changes
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews label Oct 23, 2021
@algorithms-keeper algorithms-keeper bot added awaiting reviews tests are failing labels Oct 23, 2021
@algorithms-keeper algorithms-keeper bot removed the tests are failing label Oct 23, 2021
@algorithms-keeper algorithms-keeper bot added the tests are failing label Oct 23, 2021
@Rohanrbharadwaj
Copy link
Contributor

@Rohanrbharadwaj Rohanrbharadwaj commented Oct 23, 2021

@cclauss There's a trailing space on line 39 of graphs/bidirectional_breadth_first_search.py

@algorithms-keeper algorithms-keeper bot removed the tests are failing label Oct 23, 2021
@cclauss cclauss requested a review from Kush1101 as a code owner Oct 23, 2021
@algorithms-keeper algorithms-keeper bot added the tests are failing label Oct 23, 2021
@algorithms-keeper algorithms-keeper bot removed the tests are failing label Oct 23, 2021
@cclauss cclauss merged commit bd9464e into master Oct 23, 2021
5 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews label Oct 23, 2021
@cclauss cclauss deleted the long-running-tests branch Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

@onlinejudge95 onlinejudge95

@Kush1101 Kush1101

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cclauss @Rohanrbharadwaj @poyea