Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible loss of data warnings when building 32bit executable since 3.11 #92434

Closed
2 tasks done
neonene opened this issue May 7, 2022 · 2 comments · Fixed by #93090
Closed
2 tasks done

Possible loss of data warnings when building 32bit executable since 3.11 #92434

neonene opened this issue May 7, 2022 · 2 comments · Fixed by #93090
Assignees
@erlend-aasland
Labels
expert-sqlite3 expert-subinterpreters type-bug

Comments

@neonene
Copy link
Contributor

@neonene neonene commented May 7, 2022 •
edited by erlend-aasland

Windows (x86) buildbot shows two warnings on main branch:

  • channel_list_all() in _xxsubinterpretersmodule.c, using PyList_SET_ITEM() function
D:\a\cpython\cpython\Modules\_xxsubinterpretersmodule.c(2341,9): warning C4244:
'function': conversion from 'int64_t' to 'Py_ssize_t', possible loss of data

  • serialize_impl() in _sqlite/connection.c
D:\a\cpython\cpython\Modules\_sqlite\connection.c(2122,53): warning C4244:
'function': conversion from 'sqlite3_int64' to 'Py_ssize_t', possible loss of data

I'm not sure how to deal with them.
@neonene neonene added the type-bug label May 7, 2022
@neonene neonene changed the title Possible loss of data warnings when building 32bit executable on Windows Possible loss of data warnings when building 32bit executable on Windows (_sqlite/_xxsubinterpretersmodule) May 8, 2022
@neonene neonene changed the title Possible loss of data warnings when building 32bit executable on Windows (_sqlite/_xxsubinterpretersmodule) Possible loss of data warnings when building 32bit executable on Windows (_xxsubinterpreters&_sqlite) May 8, 2022
neonene added a commit to neonene/cpython that referenced this issue May 23, 2022
@neonene
pythongh-92434: Silence a compiler warning in _sqlite/connection.c fo…
893665d 
…r 32bit version
@erlend-aasland erlend-aasland self-assigned this May 23, 2022
neonene added a commit to neonene/cpython that referenced this issue May 23, 2022
@neonene
pythongh-92434: Silence a compiler warning in _xxsubinterpretersmodul…
cd9c48f 
…e.c for 32bit version
@neonene neonene mentioned this issue May 23, 2022
Merged
@neonene neonene mentioned this issue May 23, 2022
Merged
corona10 pushed a commit that referenced this issue May 25, 2022
@neonene
gh-92434: Silence a compiler warning in _xxsubinterpretersmodule.c fo…
ac1dcb8 
…r 32bit version (gh-93091)
@erlend-aasland erlend-aasland linked a pull request May 25, 2022 that will close this issue
gh-92434: Silence a compiler warning in _sqlite/connection.c for 32bit version #93090
Merged
@neonene neonene changed the title Possible loss of data warnings when building 32bit executable on Windows (_xxsubinterpreters&_sqlite) Possible loss of data warnings when building 32bit executable since 3.11 May 26, 2022
erlend-aasland pushed a commit that referenced this issue Jun 10, 2022
@neonene
gh-92434: Silence compiler warning in Modules/_sqlite/connection.c on…
d8395eb 
… 32-bit systems (#93090)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 10, 2022
@neonene @miss-islington
pythongh-92434: Silence compiler warning in Modules/_sqlite/connectio…
0ba65f4 
…n.c on 32-bit systems (pythonGH-93090)

(cherry picked from commit d8395eb)

Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
miss-islington added a commit that referenced this issue Jun 10, 2022
@miss-islington @neonene
gh-92434: Silence compiler warning in Modules/_sqlite/connection.c on…
f384a8e 
… 32-bit systems (GH-93090)

(cherry picked from commit d8395eb)

Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 10, 2022

Fixed with the following PRs:

@neonene
Copy link
Contributor Author

@neonene neonene commented Jun 10, 2022

For the record, there is a slight possibility that _sqlite/connection.c is just silenced.
I won't open an issue without a reproducer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
expert-sqlite3 expert-subinterpreters type-bug
Projects
Subinterpreters
Status: Done
sqlite3 issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-92434: Silence a compiler warning in _sqlite/connection.c for 32bit version neonene/cpython
2 participants
@erlend-aasland @neonene