Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-79512: Fixed names and __module__ value of weakref classes #93719

Merged
merged 1 commit into from Jun 14, 2022
Merged

gh-79512: Fixed names and __module__ value of weakref classes #93719

merged 1 commit into from Jun 14, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 11, 2022

Classes ReferenceType, ProxyType and CallableProxyType have now correct
attributes __module__, __name__ and __qualname__. It makes them pickleable.

#79512

@serhiy-storchaka
pythongh-79512: Fixed names and __module__ value of weakref classes
9c04de8 
Classes ReferenceType, ProxyType and CallableProxyType have now correct
atrtributes __module__, __name__ and __qualname__. It makes them pickleable.
@serhiy-storchaka serhiy-storchaka merged commit 8352e32 into python:main Jun 14, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 14, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the weakref-class-names branch Jun 14, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 14, 2022
@serhiy-storchaka @miss-islington
pythongh-79512: Fixed names and __module__ value of weakref classes (p…
b0bf575 
…ythonGH-93719)

Classes ReferenceType, ProxyType and CallableProxyType have now correct
atrtributes __module__, __name__ and __qualname__.
It makes them (types, not instances) pickleable.
(cherry picked from commit 8352e32)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 14, 2022

GH-93789 is a backport of this pull request to the 3.11 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 14, 2022

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8352e322e87ba39c71e578b65ad8ae156ca3e0c7 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 14, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 14, 2022

Sorry @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8352e322e87ba39c71e578b65ad8ae156ca3e0c7 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 14, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 14, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit that referenced this issue Jun 14, 2022
@miss-islington @serhiy-storchaka
gh-79512: Fixed names and __module__ value of weakref classes (GH-93719)
29c7e81 
Classes ReferenceType, ProxyType and CallableProxyType have now correct
atrtributes __module__, __name__ and __qualname__.
It makes them (types, not instances) pickleable.
(cherry picked from commit 8352e32)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
needs backport to 3.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serhiy-storchaka @miss-islington @bedevere-bot