gh-84461: Fix circulare dependency on BUILDPYTHON (GH-93977) #93977
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
skip news
bedevere-bot
added
awaiting core review
and removed
arhadthedev
reviewed
Jun 18, 2022
Cross-builds do not need BUILDPYTHON to build extensions. They use an external build python interpreter. Emscripten browser builds had a circular on WASM_ASSETS -> pybuilddir.txt -> sysconfig_data -> python.js -> WASM_ASSETS.
tiran
changed the title
|
Thanks @tiran for the PR |
|
GH-93979 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jun 18, 2022
(cherry picked from commit 084023ccbeb3bf54a2e19873c6a4b0bec7b617f6) Co-authored-by: Christian Heimes <christian@python.org>
miss-islington
added a commit
that referenced
this issue
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Cross-builds do not need BUILDPYTHON to build extensions. They use an
external build python interpreter. Emscripten browser builds had a
circular on WASM_ASSETS -> pybuilddir.txt -> sysconfig_data -> python.js
-> WASM_ASSETS.