digital root method #6140
Open
digital root method #6140
+48
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
enhancement
fixed syntax, readibility, indentation
|
@poyea , sorry to disturb, the pre-commits in my pull requests keep failing although everything seems alright with the code. the workflow keeps telling me to add blank lines, but it never lets the checks go through even when i add them. could you please reccomend something to fix this issue? |
fixed pre-commit issues
|
|
fixed the Value Error [ 73d line ]
|
@Kush1101 could you please check out this pull request? |
added an exception for an invalid input, as well as tests regarding it.
|
@Kush1101 could you please check out this pull request? |
poyea
reviewed
Jul 3, 2022
| try: | ||
| return n % 9 or n and 9 if n >= 0 else "Input wasn't valid" | ||
| except TypeError: | ||
| return "Please enter a non-negative integer" |
There was a problem hiding this comment.
Suggested change
| try: | |
| return n % 9 or n and 9 if n >= 0 else "Input wasn't valid" | |
| except TypeError: | |
| return "Please enter a non-negative integer" | |
| try: | |
| return n % 9 or n and 9 if n >= 0 else "Input wasn't valid" | |
| except TypeError: | |
| return "Please enter a non-negative integer" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Describe your change:
added the 'digital_root' method to maths/sum_of_digits.py.
a digital root is: https://en.wikipedia.org/wiki/Digital_root
Checklist:
Fixes: #{$ISSUE_NO}.