ci: 👷 add zip files to github releases
#1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, I think it's good. I had to disable webpack-terser parallelism to pass CircleCI without it running out of memory, which also seems to be what's effecting other PRs. |
Conflicts: yarn.lock
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
closes #1574
adds a release github workflow that runs through the build and test process on releases but attaches the zip files as artifacts to the github release, so people in offline environments have an easy way install it with a single file.
Darkreader already does this; I've used their github workflow as a template and adapted it accordingly.
I did run into the issue that
zipcli is not cross-platform, so I had to addarchiver, and wrote a quick script to do the same that was being done with the other tools.I also added a section that will run if it's not in CI that will reuse some packages already in the dependency tree to provide progress bars when zipping files to help with debugging it.
See https://github.com/josh-hemphill/devtools/releases/tag/v6.4.0 for what the successful release with artifacts looks like.