Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-51574: Make tempfile.mkdtemp() always return absolute paths #94612

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-51574: Make tempfile.mkdtemp() always return absolute paths #94612

wants to merge 7 commits into from
+14 −1

Conversation

kj7rrv
Copy link
Contributor

@kj7rrv kj7rrv commented Jul 6, 2022

Closes #51574

Issue: gh-51574

@kj7rrv kj7rrv mentioned this pull request Jul 6, 2022
Closed
@kj7rrv
Copy link
Contributor Author

@kj7rrv kj7rrv commented Jul 6, 2022

@merwok a9098be adds a test

@kj7rrv
Copy link
Contributor Author

@kj7rrv kj7rrv commented Jul 6, 2022

I tested the test both with and without the fix, and it passes with the fix and fails without it.

merwok
merwok reviewed Jul 7, 2022
View changes
Doc/library/tempfile.rst Outdated Show resolved Hide resolved
merwok
merwok reviewed Jul 7, 2022
View changes
Lib/test/test_tempfile.py Outdated Show resolved Hide resolved
merwok
merwok reviewed Jul 7, 2022
View changes
Lib/test/test_tempfile.py Outdated Show resolved Hide resolved
merwok
merwok reviewed Jul 7, 2022
View changes
Lib/test/test_tempfile.py Outdated Show resolved Hide resolved
kj7rrv and others added 2 commits Jul 7, 2022
@kj7rrv @merwok
Update Doc/library/tempfile.rst
a65f152 
Co-authored-by: Éric <merwok@netwok.org>
@kj7rrv
Fix test
ff507d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tempfile.mkdtemp() does not return absolute pathname when relative dir is specified
3 participants
@kj7rrv @merwok @bedevere-bot