gh-78486: Unwrap decorators in getfile, rather than downstream #8602
+44
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
inspect-source
branch
2 times, most recently
from
904b878 to
d844e4c
Compare
|
@eric-wieser yesterday, there was an other commit with the unwrap function, is it right? |
1st1
reviewed
Aug 2, 2018
Among other functions, this fixes getsourcefile and getcomments. Removes some code duplication while I'm here
eric-wieser
force-pushed
the
inspect-source
branch
from
d844e4c to
d874835
Compare
|
@matrixise: If you're asking if the @1st1: Fixed |
|
Ping |
|
@1st1, would you mind re-reviewing? |
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
picnixz
changed the title
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other functions, this fixes getsourcefile and getcomments.
https://bugs.python.org/issue34305