New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce code repetition #758
Comments
Yep sure, I will take a look next week. |
Hey, I wanna do it. Please assign it to me. |
@littlefermatlives Please open a pull request and do the changes. I will review it. |
If anyone finds some of those and either doesn't want to work on them or don't have to knowledge of the function, feel free to share here so others can do it. I feel like it would also be a good idea for someone to make a checklist on those files that have been throughly checked for these and don't need any more review. |
Hello, /Students from Royal Institute of Technology |
@benronkth If you have any questions or face any issues, feel free to ask in this thread. |
There is a function called rotate (angleInRadians) in two files, namely:
As you see they should be doing the same operation but there is a conversion happening in the second file |
Since the second one is first converting to radians and then essentially running the first function, we can rewrite the second one in terms of the first. |
raklaptudirm commentedOct 8, 2021
•
edited
We have now successfully added guidelines for importing and using algorithms in this repository, inside other algorithms. This has been done to reduce code repetition and uphold code quality. Some functions do implement their own versions of data structures and helper functions, as previously, algorithms were supposed to be completely self contained. This issue initiates a search and fix so that all functions and data structures which can be imported in an algorithm should be imported.
Also as an addition to the topic, this initiative should also weed out bad code, i.e.:
The text was updated successfully, but these errors were encountered: