Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📚] The docs should return the manual setup since the CLI doesn't cover flavors #8918

Open
feinstein opened this issue Jun 15, 2022 · 5 comments
Labels
good first issue type: documentation type: enhancement

Comments

@feinstein
Copy link
Contributor

@feinstein feinstein commented Jun 15, 2022

As shown in this issue the CLI doesn't support Android Flavors and Dimensions or iOS Schemes and Targets, so we can't use the CLI to setup our Firebase projects.

Until recently the setup docs included manual instructions and automated instructions, but now there's only the automated option through the CLI, leaving everyone with flavors/schemes incapable of adopting Firebase with Flutter, or updating the libraries to get the benefits, like better Crashlytics behavior with Flutter.

I believe the manual configuration option should return while the CLI doesn't cover this use cases.

@feinstein feinstein added good first issue type: documentation labels Jun 15, 2022
@darshankawar darshankawar added the type: enhancement label Jun 20, 2022
@neiljaywarner
Copy link

@neiljaywarner neiljaywarner commented Jun 30, 2022

@feinstein @darshankawar is this correct? If this is correct this influces whether flavors should be used at all imho.
Is there any documentation about best practice about if flavors are "critical" or if environment switcher and specific crashlytics/analytics urls and filtering are sufficient?

@feinstein
Copy link
Contributor Author

@feinstein feinstein commented Jul 1, 2022

@neiljaywarner there are situations where flavors are critical. Imagine a project that needs a Cloud Firestore data base for production and another for development, or as in my case, several whitelabel apps that share the same code, but only have different names and package ids, so we would need to configure FlutterFire to deal with all the 4 android apps that use that same project, and not only one Android app.

Unfortunately there aren't many official guidelines, although you can find lots of recommendations online, but here's one of the offcial docs

@neiljaywarner
Copy link

@neiljaywarner neiljaywarner commented Jul 1, 2022

@feinstein
Copy link
Contributor Author

@feinstein feinstein commented Jul 1, 2022

Well, do you see how this would be possible for my use case?

I have 6 different white label apps (and growing), that I want to share the same Firebase, so I can have all the Crashlytics and remote configs at the same place.

Also, I want them to have a separate environment for development and production.

This works fine right now, and that's a functionality that Firebase supports, I am not inventing anything new, Firebase allows me to connect as many Android apps to one project as I want, so why the CLI shouldn't support something that Firebase already supports?

Also, there are many production apps like this, should we try to see how to change them all? How about data migrations for all of them?

I think it's simpler to just change the CLI, and while it doesn't get fixed, we rollback the manual configuration tutorials.

@neiljaywarner
Copy link

@neiljaywarner neiljaywarner commented Jul 1, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue type: documentation type: enhancement
Projects
None yet
Development

No branches or pull requests

4 participants